[PATCH] D57323: [WebAssembly] Enable main-function signature rewriting for WASI

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 15:37:33 PST 2019


sunfish added a comment.

In D57323#1374572 <https://reviews.llvm.org/D57323#1374572>, @sbc100 wrote:

> I mean with your fix we don't need this to be wasi specific do we?


It needs to align with what crt1.o does though, which is specific to the OS. For WASI's crt1.o, my current working theory is to just support the two standard-required cases and not the `envp` case. But for the `unknown` OS, we don't know what people might want to link to.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57323/new/

https://reviews.llvm.org/D57323





More information about the llvm-commits mailing list