[PATCH] D57256: gn build: Add get.py script to download prebuilt gn, make gn.py run downloaded gn if gn is not on PATH

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/gn/get.py:31
+    mode = os.stat(path).st_mode
+    mode |= (mode & 0o444) >> 2 # Copy R bits to X.
+    os.chmod(path, mode) # No-op on Windows.
----------------
Fancy :-)


================
Comment at: llvm/utils/gn/get.py:55
+    url = 'https://chrome-infra-packages.appspot.com/dl/gn/gn/%s-amd64/+/latest'
+    gn = 'gn' + ('.exe' if sys.platform == 'win32' else '')
+    download_and_unpack(url % platform, dirname, gn)
----------------
the url doesn't end in .zip or something?


================
Comment at: llvm/utils/gn/get.py:57
+    download_and_unpack(url % platform, dirname, gn)
+    set_executable_bit(os.path.join(dirname, gn))
+
----------------
if it's a zip file, i'm surprised this is necessary


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57256/new/

https://reviews.llvm.org/D57256