[PATCH] D57247: Simply operands of masked stores and scatters based on demanded elements

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 11:32:57 PST 2019


reames added a comment.

In D57247#1372418 <https://reviews.llvm.org/D57247#1372418>, @RKSimon wrote:

> I agree some kind of helper function that can extract vector values from various Constant vector forms would be useful - they do keep turning up in code in various guises (and if you do gathers/maskedloads you'll be duplicating the code yet again!).


Mind if I do this in a follow up commit?  And can you point me to a few places that duplicate this?  I'm just getting up to speed on how we handle masks and don't have the code indexed in my head yet.  :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57247/new/

https://reviews.llvm.org/D57247





More information about the llvm-commits mailing list