[PATCH] D57309: [LangRef] Mention vector support for bitreverse/bswap intrinsics (PR38012)

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline for some wording/grammar nits.



================
Comment at: docs/LangRef.rst:12249
 The '``llvm.bitreverse``' family of intrinsics is used to reverse the
-bitpattern of an integer value; for example ``0b10110110`` becomes
-``0b01101101``.
+bitpattern of an integer value or vector of integers values; for example
+``0b10110110`` becomes ``0b01101101``.
----------------
integers values -> integer values


================
Comment at: docs/LangRef.rst:12257
+``M`` in the input moved to bit ``N-M`` in the output. The vector
+intrinsics, such as ``llvm.bitreverse.v4i32``, perform on a per-element
+basis, the element order is not affected.
----------------
perform -> operate?


================
Comment at: docs/LangRef.rst:12258
+intrinsics, such as ``llvm.bitreverse.v4i32``, perform on a per-element
+basis, the element order is not affected.
 
----------------
Run-on sentence: change comma after 'basis' to period or semi-colon.


================
Comment at: docs/LangRef.rst:12279-12280
 
-The '``llvm.bswap``' family of intrinsics is used to byte swap integer
-values with an even number of bytes (positive multiple of 16 bits).
-These are useful for performing operations on data that is not in the
-target's native byte order.
+The '``llvm.bswap``' family of intrinsics is used to byte swap integer or
+vector of integers with values with an even number of bytes (positive
+multiple of 16 bits). These are useful for performing operations on data that
----------------
...family of intrinsics is used to byte swap an integer value or vector of integer values...


================
Comment at: docs/LangRef.rst:12282
+multiple of 16 bits). These are useful for performing operations on data that
+is not in the target's native byte order.
 
----------------
...operations on data that are not...

Or just remove that sentence? Doesn't add much value IMO.


================
Comment at: docs/LangRef.rst:12295
+respectively). The vector intrinsics, such as ``llvm.bswap.v4i32``,
+perform on a per-element basis, the element order is not affected.
 
----------------
Run-on sentence: change comma after 'basis' to period or semi-colon.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57309/new/

https://reviews.llvm.org/D57309