[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

Mon Jan 28 08:06:56 PST 2019

yroux marked an inline comment as done.
yroux added a comment.

Thanks for the review David,

what kind of outliers have you seen ? So far the only cases of code size being increase with outlining is due to some padding added to align the oulined functions.

================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:5431
+  unsigned AddrMode = (MI->getDesc().TSFlags & ARMII::AddrModeMask);
+  int Idx = MI->findRegisterUseOperandIdx(ARM::SP) + 1;
+  int64_t Offset = 0;
----------------
dmgreen wrote:
> What if we are actually storing sp? As in something like,
> t2STRi8 $sp, $r7, 12, ...
hmm, there might be an issue if the stored value (with a fix-up) is used after the outlined code indeed, I think that this kind of issue didn't occurred in my tests because of the constraints made at lines 5645-5697, I'll try to exhibit the issue with an mir test. 

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57054/new/

https://reviews.llvm.org/D57054