[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:36
+      string(STRIP "${git_output}" git_output)
+      get_filename_component(git_dir ${git_output} ABSOLUTE)
+      if(EXISTS "${git_dir}/svn/refs")
----------------
smeenai wrote:
> This needs `BASE_DIR "${path}"`, right?
I don't know if it's really necessary (it worked fine without in my testing) but I'm fine including it.


================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:43
+        if(git_result EQUAL 0)
+          string(REGEX REPLACE "^(.*\n)?Revision: ([^\n]+).*"
+            "\\2" git_svn_rev "${git_output}")
----------------
mgorny wrote:
> Hmm, I'm wondering if it's possible to make `subversion_wc_info` to work on top of git-svn.
I tried it briefly but couldn't make it work because git-svn metadata isn't a Subversion checkout.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57063/new/

https://reviews.llvm.org/D57063