[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

[Petr Hosek via Phabricator via llvm-commits]

phosek updated this revision to Diff 183782.
phosek marked 10 inline comments as done.
phosek added a comment.

I had to do some more refactoring, but I managed to factor out the `.undef` handling altogether as suggested by @mgorny. Let me know if this is still OK to land.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57063/new/

https://reviews.llvm.org/D57063

Files:
  clang/lib/Basic/CMakeLists.txt
  clang/lib/Basic/Version.cpp
  llvm/CMakeLists.txt
  llvm/cmake/modules/AddLLVM.cmake
  llvm/cmake/modules/GenerateVersionFromCVS.cmake
  llvm/cmake/modules/GenerateVersionFromVCS.cmake
  llvm/cmake/modules/GetSVN.cmake
  llvm/cmake/modules/VersionFromVCS.cmake
  llvm/include/llvm/Support/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57063.183782.patch
Type: text/x-patch
Size: 25309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190128/6c786fd2/attachment.bin>