[PATCH] D46754: [AMDGPU] Add intrinsics for 16 bit interpolation

Tim Corringham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 09:33:43 PST 2019


timcorringham marked 2 inline comments as done.
timcorringham added inline comments.


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.interp.f16.ll:57
+}
+
+; float @llvm.amdgcn.interp.p1.f16(i, attrchan, attr, high, m0)
----------------
arsenm wrote:
> Can you add a test case with LDS usage to make sure m0 is properly restored after?
I have added test cases to check that m0 is set up before each of the interp f16 instructions if necessary. I have done this by explicitly writing to m0 rather than using LDS as I couldn't see a way to do the latter, and other tests use the technique of writing to m0.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46754/new/

https://reviews.llvm.org/D46754





More information about the llvm-commits mailing list