[PATCH] D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

Code lgtm, just have nits on the testing. Thanks!



================
Comment at: test/tools/llvm-objcopy/ELF/help-message.test:14
 # RUN: not llvm-strip --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
 # RUN: not llvm-strip --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
 
----------------
Not related to this patch really, but --strip-debug isn't needed for this test case -- the same error message should be printed with just llvm-strip (no args)


================
Comment at: test/tools/llvm-objcopy/ELF/strip-debug.test:10
+# RUN: llvm-objcopy -g %t %t2g
+# Verify that --strip-debug and -g produce the same output
+# RUN: cmp %t2 %t2g
----------------
This test -- running cmp against -g and --strip-debug output -- is really all that's needed. Duplication in all the other tests is not providing any more coverage. I think it's safe to revert all the other test files and all other modifications in this file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57217/new/

https://reviews.llvm.org/D57217