[PATCH] D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: test/tools/llvm-objcopy/COFF/only-section.test:13
+RUN: llvm-objcopy --only-section .debug_discardable --only-section .text -g %t.in.exe %t.combination_g.exe
+RUN: llvm-objdump --section-headers -t %t.combination_g.exe | FileCheck %s --check-prefixes=SECTIONS,SECTIONS-TEXT,SYMBOLS,SYMBOLS-TEXT
+
----------------
i don't have a strong opinion regarding this, but generally when the output is expected to be exactly the same i wouldn't do text matching twice (it all contributes to the time it takes to run all the tests), i'd simply run cmp %t.combination.exe %t.combination_g.exe - it's much cheaper. 

p.s. maybe there are other similar places, pls, have a look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57217/new/

https://reviews.llvm.org/D57217