[PATCH] D55444: AMDGPU: Fix DPP combiner
Valery Pykhtin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 24 07:53:19 PST 2019
vpykhtin updated this revision to Diff 183315.
vpykhtin added a comment.
Fixed issue with old = dpp src register when bound ctrl is off.
Slightly refactored and simplified. Description is corrected, though it's not one-to-one maps on the code as there're other things to do (as reusing IMPLICIT_DEF instructions)
Variable names changed to be more consistent with the description.
I decided to left current commutation as is because it doesn't come for free: it may create new instructions (at least reversed instructions) and for that reason previous analisys (like SlotIndexes) should be invalidated.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55444/new/
https://reviews.llvm.org/D55444
Files:
include/llvm/CodeGen/TargetInstrInfo.h
lib/Target/AMDGPU/GCNDPPCombine.cpp
lib/Target/AMDGPU/SIInstrInfo.cpp
lib/Target/AMDGPU/SIInstrInfo.h
test/CodeGen/AMDGPU/dpp_combine.ll
test/CodeGen/AMDGPU/dpp_combine.mir
test/CodeGen/AMDGPU/dpp_combine_subregs.mir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55444.183315.patch
Type: text/x-patch
Size: 49696 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190124/706a3540/attachment.bin>
More information about the llvm-commits
mailing list