[PATCH] D56774: Build LLVM-C.dll by default on windows and enable in release package

Thu Jan 24 06:38:24 PST 2019

serge-sans-paille accepted this revision.
serge-sans-paille added inline comments.

================
Comment at: CMakeLists.txt:537
 if(MSVC)
-  option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" OFF)
+  option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" ON)
 else()
----------------
Wallbraker wrote:
> serge-sans-paille wrote:
> > out of curiosity: does it make sense to have this turned ON by default, while it's OFF for darwin?
> Due to the way c-runtimes and different compiler works (or doesn't work) getting a usable DLL is more valuable on Windows then on Mac. It doesn't add much build time and makes sure that the building of the LLVM-C.dll is better tested.
ok, LGTM then.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56774/new/

https://reviews.llvm.org/D56774