[PATCH] D56774: Build LLVM-C.dll by default on windows and enable in release package
Jakob Bornecrantz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 24 05:49:04 PST 2019
Wallbraker marked an inline comment as done.
Wallbraker added inline comments.
================
Comment at: CMakeLists.txt:537
if(MSVC)
- option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" OFF)
+ option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" ON)
else()
----------------
serge-sans-paille wrote:
> out of curiosity: does it make sense to have this turned ON by default, while it's OFF for darwin?
Due to the way c-runtimes and different compiler works (or doesn't work) getting a usable DLL is more valuable on Windows then on Mac. It doesn't add much build time and makes sure that the building of the LLVM-C.dll is better tested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56774/new/
https://reviews.llvm.org/D56774
More information about the llvm-commits
mailing list