[PATCH] D57085: [RISCV] Custom-legalise 32-bit variable shifts on RV64

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:47:09 PST 2019


efriedma added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.h:37
+  SRAW,
+  SRLW
 };
----------------
Probably worth explicitly noting whether the shift amount is modulo.  If it is, you might want to implement SimplifyDemandedBitsForTargetNode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57085/new/

https://reviews.llvm.org/D57085





More information about the llvm-commits mailing list