[PATCH] D57044: [AArch64] Optimize Inf materialization

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 09:34:42 PST 2019


efriedma added a comment.

Is there some reason we're checking for specific floating-point constants here, as opposed to just calling AArch64_AM::isLogicalImmediate or AArch64_AM::isAnyMOVWMovAlias?



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5430
+  // We can materialize #0.0 and #INF as fmov $Rd, XZR for 64-bit and 32-bit
+  // cases.
   // FIXME: We should be able to handle f128 as well with a clever lowering.
----------------
This comment is wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57044/new/

https://reviews.llvm.org/D57044





More information about the llvm-commits mailing list