[PATCH] D57009: [llvm-objcopy] [COFF] Fix handling of aux symbols for big objects

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 02:09:16 PST 2019


jhenderson added a comment.

In D57009#1367446 <https://reviews.llvm.org/D57009#1367446>, @mstorsjo wrote:

> > By the way, there's a gunzip.py script in the ELF/Inputs directory, which you should probably move to a shared area and use for decompressing.
>
> Hmm, what place would that be, where it's findable by python within the lit tests? I could just move it up into `test/tools/llvm-objcopy/Inputs` and refer to it with `%p/../Inputs/ungzip.py` in the ELF/COFF subdirs - not ideal or elegant or anything, but at least shared between these two directories.


That's where I'd put it. No point in duplicating it after all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57009/new/

https://reviews.llvm.org/D57009





More information about the llvm-commits mailing list