[PATCH] D57009: [llvm-objcopy] [COFF] Fix handling of aux symbols for big objects

Wed Jan 23 02:00:15 PST 2019

mstorsjo added a comment.

In D57009#1367445 <https://reviews.llvm.org/D57009#1367445>, @jhenderson wrote:

> In D57009#1367437 <https://reviews.llvm.org/D57009#1367437>, @mstorsjo wrote:
>
> > I'm experimenting with crafting such an input file now. The uncompressed object file weighs in at around 5 MB, and after gzip (as is used for that ELF test) it currently ends up at around 725 KB. Do you think that's acceptable or too large?
>
>
> It's not ideal, if I'm honest, but it might be a quirk of the file format, and therefore unavoidable. The equivalent file for ELF is only 152 KB. I don't know if it was somehow more aggressively compressed though. If you can't get it any smaller, I think it's probably acceptable.

Ok then. At least it makes for a better testcase.

> By the way, there's a gunzip.py script in the ELF/Inputs directory, which you should probably move to a shared area and use for decompressing.

Hmm, what place would that be, where it's findable by python within the lit tests? I could just move it up into `test/tools/llvm-objcopy/Inputs` and refer to it with `%p/../Inputs/ungzip.py` in the ELF/COFF subdirs - not ideal or elegant or anything, but at least shared between these two directories.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57009/new/

https://reviews.llvm.org/D57009