[PATCH] D57048: [SystemZ] Handle DBG_VALUE instructions in two places in backend

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 182911.
jonpa added a comment.

> What's the reason for using SkipPHIsLabelsAndDebug instead of, say, skipDebugInstructionsForward? It's not obvious to me that skipping PHIs and labels is safe at all those places ...

No reason in particular, and I agree that skipDebugInstructionsForward() seems like a better choice. Patch updated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57048/new/

https://reviews.llvm.org/D57048

Files:
  lib/Target/SystemZ/SystemZElimCompare.cpp
  lib/Target/SystemZ/SystemZISelLowering.cpp
  test/CodeGen/SystemZ/debuginstr-00.mir
  test/CodeGen/SystemZ/debuginstr-01.mir
  test/CodeGen/SystemZ/debuginstr-02.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57048.182911.patch
Type: text/x-patch
Size: 12433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190122/d836105e/attachment.bin>