[PATCH] D57048: [SystemZ] Handle DBG_VALUE instructions in two places in backend

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 06:09:19 PST 2019


uweigand added a comment.

What's the reason for using SkipPHIsLabelsAndDebug instead of, say, skipDebugInstructionsForward?   It's not obvious to me that skipping PHIs and labels is safe at all those places ...

Otherwise, this looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57048/new/

https://reviews.llvm.org/D57048





More information about the llvm-commits mailing list