[PATCH] D57007: [llvm-objcopy] [COFF] Implement --add-gnu-debuglink

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 08:40:52 PST 2019


jhenderson added inline comments.


================
Comment at: tools/llvm-objcopy/COFF/Object.h:46
+  // is used instead of Contents above.
+  std::vector<uint8_t> LocalContents;
 };
----------------
mstorsjo wrote:
> jhenderson wrote:
> > I'd probably rename this to ModifiedContents or similar. It isn't clear to me what "Local" means in this context.
> Ok - or maybe rename the old one `OrigContents` instead?
Either works for me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57007/new/

https://reviews.llvm.org/D57007





More information about the llvm-commits mailing list