[PATCH] D57007: [llvm-objcopy] [COFF] Implement --add-gnu-debuglink

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: tools/llvm-objcopy/COFF/COFFObjcopy.cpp:169
+
+  if (!Config.AddGnuDebugLink.empty() && Obj.IsPE)
+    addGnuDebugLink(Obj, Config.AddGnuDebugLink);
----------------
jhenderson wrote:
> I just want to confirm that GNU objcopy doesn't add a gnu debug link section if it is not PE?
I'll have a look.


================
Comment at: tools/llvm-objcopy/COFF/Object.h:46
+  // is used instead of Contents above.
+  std::vector<uint8_t> LocalContents;
 };
----------------
jhenderson wrote:
> I'd probably rename this to ModifiedContents or similar. It isn't clear to me what "Local" means in this context.
Ok - or maybe rename the old one `OrigContents` instead?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57007/new/

https://reviews.llvm.org/D57007