[PATCH] D35989: [SCEV][NFC] Introduces expression sizes estimation

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 20 20:41:48 PST 2019


mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:396
 SCEVCouldNotCompute::SCEVCouldNotCompute() :
-  SCEV(FoldingSetNodeIDRef(), scCouldNotCompute) {}
+  SCEV(FoldingSetNodeIDRef(), scCouldNotCompute, 0) {}
 
----------------
reames wrote:
> You missed a 0 -> 1
It's okay here, because `SCEVCouldNotCompute` can never be a part of another expression. It is only used to signal that SCEV was unable to construct a SCEV.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35989/new/

https://reviews.llvm.org/D35989





More information about the llvm-commits mailing list