[PATCH] D35989: [SCEV][NFC] Introduces expression sizes estimation

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.

LGTM w/one required change before commit and one optional encouraged one.



================
Comment at: include/llvm/Analysis/ScalarEvolutionExpressions.h:143
   class SCEVNAryExpr : public SCEV {
+    static unsigned short computeExpressionSize(size_t N,
+                                                const SCEV *const *O) {
----------------
Stylistically, I'd recommend using a single helper function w/an arrayref argument.  It can replace all of the helpers you've got here.  This is an optional change, can be made before or after initial submit.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:396
 SCEVCouldNotCompute::SCEVCouldNotCompute() :
-  SCEV(FoldingSetNodeIDRef(), scCouldNotCompute) {}
+  SCEV(FoldingSetNodeIDRef(), scCouldNotCompute, 0) {}
 
----------------
You missed a 0 -> 1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35989/new/

https://reviews.llvm.org/D35989