[llvm] r351526 - [AVR] Rewrite the CBRRdK instruction as an alias of ANDIRdK

Dylan McKay via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 19 19:45:57 PST 2019


Good catch, I've updated the comments in r351674, thanks!

On Sat, Jan 19, 2019 at 8:08 AM Eli Friedman <efriedma at codeaurora.org>
wrote:

> On 1/17/2019 11:31 PM, Dylan McKay via llvm-commits wrote:
> > Author: dylanmckay
> > Date: Thu Jan 17 23:31:34 2019
> > New Revision: 351526
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=351526&view=rev
> > Log:
> > [AVR] Rewrite the CBRRdK instruction as an alias of ANDIRdK
> > +// imm_com8_XFORM - Return the complement of a t2_so_imm value
> > +def imm_com8_XFORM : SDNodeXForm<imm, [{
> > +  return CurDAG->getTargetConstant(~((uint8_t)N->getZExtValue()),
> SDLoc(N),
> > +                                   MVT::i8);
> > +}]>;
>
> The comment refers to t2_so_imm?
>
> > +
> > +// imm_com8 - Match an immediate that is a complement
> > +// of a 8-bit immediate.
> > +// Note: this pattern doesn't require an encoder method and such, as
> it's
> > +// only used on aliases (Pat<> and InstAlias<>). The actual encoding
> > +// is handled by the destination instructions, which use t2_so_imm.
>
> Also here, refers to t2_so_imm
>
> -Eli
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
> Foundation Collaborative Project
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190120/d787d836/attachment.html>


More information about the llvm-commits mailing list