[PATCH] D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit()

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 18 15:43:32 PST 2019


rupprecht updated this revision to Diff 182621.
rupprecht marked an inline comment as done.
rupprecht added a comment.

- Add comment about using createFileError


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56930/new/

https://reviews.llvm.org/D56930

Files:
  llvm/test/tools/llvm-objcopy/ELF/fail-no-output-directory.test
  llvm/tools/llvm-objcopy/Buffer.cpp
  llvm/tools/llvm-objcopy/Buffer.h
  llvm/tools/llvm-objcopy/COFF/Writer.cpp
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/ELF/Object.cpp
  llvm/tools/llvm-objcopy/ELF/Object.h
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56930.182621.patch
Type: text/x-patch
Size: 9595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190118/93d5122f/attachment.bin>


More information about the llvm-commits mailing list