[PATCH] D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit()

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

i have one inline comment, but otherwise this looks good to me



================
Comment at: llvm/tools/llvm-objcopy/Buffer.cpp:25
+  if (!BufferOrErr)
+    return createFileError(getName(), BufferOrErr.takeError());
   Buf = std::move(*BufferOrErr);
----------------
just in case: why do we use createFileError here instead of propagating the original error BufferOrErr.takeError() ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56930/new/

https://reviews.llvm.org/D56930