[PATCH] D55839: [elfabi] Add support for writing ELF header for binary stubs
Armando Montanez via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 18 12:50:42 PST 2019
amontanez updated this revision to Diff 182586.
amontanez marked 18 inline comments as done.
amontanez added a reviewer: ruiu.
amontanez added a comment.
This should address most of the comments. All functions except for the single `writeBinaryStub()` have become static functions, and the class has been removed. I'll be updating D55864 <https://reviews.llvm.org/D55864> to match these changes as soon as possible.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55839/new/
https://reviews.llvm.org/D55839
Files:
llvm/test/tools/llvm-elfabi/invalid-bin-target.test
llvm/test/tools/llvm-elfabi/missing-bin-target.test
llvm/test/tools/llvm-elfabi/write-elf32be-ehdr.test
llvm/test/tools/llvm-elfabi/write-elf32le-ehdr.test
llvm/test/tools/llvm-elfabi/write-elf64be-ehdr.test
llvm/test/tools/llvm-elfabi/write-elf64le-ehdr.test
llvm/tools/llvm-elfabi/ELFObjHandler.cpp
llvm/tools/llvm-elfabi/ELFObjHandler.h
llvm/tools/llvm-elfabi/llvm-elfabi.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55839.182586.patch
Type: text/x-patch
Size: 13963 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190118/b1c3ccd5/attachment.bin>
More information about the llvm-commits
mailing list