[PATCH] D56845: [AMDGPU] Add some missing always-uniform values.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:584-585
+    case Intrinsic::amdgcn_fcmp:
+    case Intrinsic::amdgcn_s_buffer_load:
+    case Intrinsic::amdgcn_s_getpc:
       return true;
----------------
I think the presence of these two is questionable. getpc in particular should already behave correctly since it has no source operands. If s_buffer_load has divergent arguments, the program is broken anyway


================
Comment at: test/Analysis/DivergenceAnalysis/AMDGPU/always_uniform.ll:3-4
 
-define amdgpu_kernel void @workitem_id_x() #1 {
+; CHECK: for function 'workitem_id_x':
+define amdgpu_kernel void @workitem_id_x() {
   %id.x = call i32 @llvm.amdgcn.workitem.id.x()
----------------
This should probably be renamed, it's really testing readfirstlane, not work item.id.x


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56845/new/

https://reviews.llvm.org/D56845