[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

Tue Jan 15 14:20:29 PST 2019

tlively added a comment.

In D56742#1358698 <https://reviews.llvm.org/D56742#1358698>, @aheejin wrote:

> Where do you actually put the contents into the binary producer section? YAML result does not show anything.

See WebAssemblyAsmPrinter.cpp

In D56742#1358702 <https://reviews.llvm.org/D56742#1358702>, @aheejin wrote:

> In D56742#1358684 <https://reviews.llvm.org/D56742#1358684>, @tlively wrote:
>
> > In D56742#1358674 <https://reviews.llvm.org/D56742#1358674>, @tlively wrote:
> >
> > > This patch seems to break llvm-dwarfdump, used by emscripten with `-g`, so I will need to make further changes and probably add new tests.
> >
> >
> > Actually, it turns out that this is a linker bug. The linker does not know about the producers section yet, so the section ends up being placed before the name section, which makes the resulting binary invalid as far as LLVM is concerned. The fix is to implement proper producers section support in lld. Coming soon.
>
>
> Why would linker have to know to make this patch work? We didn't run any linker tests in this patch, did we?

It's more like the linker is broken in the presence of producers sections, but we didn't know until now because we never had producers sections.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742