[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Nice!

We could teach ObjectYAML to understand the contents but I don't think that is necessary for this change.



================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:154
+      const auto *S = cast<MDString>(Ident->getOperand(i)->getOperand(0));
+      std::pair<StringRef, StringRef> Field = S->getString().split("version");
+      Field.first = Field.first.trim();
----------------
What if version is not part of the ident?  Is that legal?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742