[PATCH] D56695: [X86] Add X86ISD::VSHLV and X86ISD::VSRLV nodes for psllv and psrlv

Tue Jan 15 03:27:20 PST 2019

zhutianyang marked an inline comment as done.
zhutianyang added a comment.

In D56695#1357444 <https://reviews.llvm.org/D56695#1357444>, @craig.topper wrote:

> I've committed the tests along with some formatting fixes, removal of unused operands, and a fix to minimize the diffs in avx-intrinsics-x86.ll. Can you rebase this patch and regenerate the test checks?

Ok, I will

================
Comment at: lib/Target/X86/X86InstrAVX512.td:6517
+defm : avx512_var_shift_int_lowering_mb<"VPSLLVQ", X86vshlv, v4i64x_info, [HasVLX]>;
+defm : avx512_var_shift_int_lowering_mb<"VPSLLVQ", X86vshlv, v8i64_info, [HasAVX512]>;

----------------
RKSimon wrote:
> Duplication - wrap in defm macro?
Could you share a demo to explain how to wrap it? thanks

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56695/new/

https://reviews.llvm.org/D56695