[PATCH] D55825: [FileCheck] Suppress old -v/-vv diags if dumping input
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 14 13:42:12 PST 2019
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM although I do wonder at the usefulness of the wildcards in the implicit-not checks.
================
Comment at: llvm/test/FileCheck/dump-input-annotations.txt:20
+; RUN: | FileCheck -strict-whitespace -match-full-lines -check-prefix=ALIGN \
+; RUN: -implicit-check-not='{{.*}}remark:{{.*}}' %s
+
----------------
Is this different from `-implicit-check-not='remark:'` ? I wouldn't have thought so. I mean, in a positive CHECK, you use the wildcards to hoover up the rest of the line, but in a NOT it doesn't seem useful.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55825/new/
https://reviews.llvm.org/D55825
More information about the llvm-commits
mailing list