[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

I'm happy with this approach since the triple can be set on the commandline.
If this gets merged I will update CHERI lld to use the triple instead of the new emulation that we added.



================
Comment at: ELF/Driver.cpp:757
+  if (!TargetOpt.empty()) {
+    // TODO: do we want to verify it and fail on unsupported?
+    Config->TargetTriple = llvm::Triple(TargetOpt);
----------------
I think failing on an unknown triple would be good since it can avoid user error where the wrong defaults are chosen just because of a small typo.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56650/new/

https://reviews.llvm.org/D56650