[llvm] r350653 - Revert "Work around a linker error caused by https://reviews.llvm.org/D56084."

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 13 17:56:51 PST 2019


Would be handy to include some details in the revert patch description
about why this was reverted - buildbot failure with a link to/quote from
the failure log, etc?

On Wed, Jan 9, 2019 at 7:08 AM Adrian Prantl via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: adrian
> Date: Tue Jan  8 13:05:08 2019
> New Revision: 350653
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350653&view=rev
> Log:
> Revert "Work around a linker error caused by
> https://reviews.llvm.org/D56084."
>
> This reverts commit r350650
>
> Modified:
>     llvm/trunk/tools/llvm-mca/CMakeLists.txt
>
> Modified: llvm/trunk/tools/llvm-mca/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/CMakeLists.txt?rev=350653&r1=350652&r2=350653&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llvm-mca/CMakeLists.txt (original)
> +++ llvm/trunk/tools/llvm-mca/CMakeLists.txt Tue Jan  8 13:05:08 2019
> @@ -6,8 +6,6 @@ set(LLVM_LINK_COMPONENTS
>    AllTargetsDescs
>    AllTargetsDisassemblers
>    AllTargetsInfos
> -  # FIXME: This works around a linker error with
> -DLLVM_BUILD_WITH_MODULES=1
> -  CodeGen
>    MCA
>    MC
>    MCParser
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190114/122bcd4b/attachment.html>


More information about the llvm-commits mailing list