<div dir="ltr">Would be handy to include some details in the revert patch description about why this was reverted - buildbot failure with a link to/quote from the failure log, etc?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 9, 2019 at 7:08 AM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Tue Jan  8 13:05:08 2019<br>
New Revision: 350653<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=350653&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=350653&view=rev</a><br>
Log:<br>
Revert "Work around a linker error caused by <a href="https://reviews.llvm.org/D56084" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56084</a>."<br>
<br>
This reverts commit r350650<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-mca/CMakeLists.txt<br>
<br>
Modified: llvm/trunk/tools/llvm-mca/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/CMakeLists.txt?rev=350653&r1=350652&r2=350653&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/CMakeLists.txt?rev=350653&r1=350652&r2=350653&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-mca/CMakeLists.txt (original)<br>
+++ llvm/trunk/tools/llvm-mca/CMakeLists.txt Tue Jan  8 13:05:08 2019<br>
@@ -6,8 +6,6 @@ set(LLVM_LINK_COMPONENTS<br>
   AllTargetsDescs<br>
   AllTargetsDisassemblers<br>
   AllTargetsInfos<br>
-  # FIXME: This works around a linker error with -DLLVM_BUILD_WITH_MODULES=1<br>
-  CodeGen<br>
   MCA<br>
   MC<br>
   MCParser<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>