[PATCH] D56135: Allow reverse iterators for `MachineBasicBlock::findDebugLoc` and `MachineBasicBlock::findPrevDebugLoc`

Artyom Goncharov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 13 11:16:58 PST 2019


m4yers added a comment.

In D56135#1354342 <https://reviews.llvm.org/D56135#1354342>, @fhahn wrote:

> In D56135#1347626 <https://reviews.llvm.org/D56135#1347626>, @m4yers wrote:
>
> > In D56135#1343674 <https://reviews.llvm.org/D56135#1343674>, @fhahn wrote:
> >
> > > Are there any instances in the current codebase where this would be useful?
> >
> >
> > For example `X86InstrInfo::AnalyzeBranchImpl` can be rewritten with more natural reverse iterators.
>
>
> Would it be possible to post that as a follow up patch?


This is for a downstream backend target i'm writing, but yes, I can provide patches for X86 where using this interface is more suitable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56135/new/

https://reviews.llvm.org/D56135





More information about the llvm-commits mailing list