[PATCH] D56604: [DAGCombiner] fold insert_subvector of insert_subvector

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 08:46:37 PST 2019


spatel created this revision.
spatel added reviewers: craig.topper, efriedma, RKSimon.
Herald added a subscriber: mcrosier.

This pattern:

    t33: v8i32 = insert_subvector undef:v8i32, t35, Constant:i64<0>
  t21: v16i32 = insert_subvector undef:v16i32, t33, Constant:i64<0>

...shows up in PR33758:
https://bugs.llvm.org/show_bug.cgi?id=33758
...although it doesn't make any difference to the final result.

In the affected tests here, it looks like it just makes RA wiggle. But we might as well squash this to prevent it interfering with other pattern-matching. I think there's a similar opportunity for extract-of-extract.


https://reviews.llvm.org/D56604

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/vector-reduce-mul-widen.ll
  test/CodeGen/X86/vector-reduce-mul.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56604.181286.patch
Type: text/x-patch
Size: 42984 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190111/6d89ad24/attachment.bin>


More information about the llvm-commits mailing list