[PATCH] D56401: [WebAssembly] Fix updating/moving DBG_VALUEs in RegStackify
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 11 22:55:06 PST 2019
aheejin added inline comments.
================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:19
+
+#include "llvm/CodeGen/MachineBasicBlock.h"
+
----------------
aheejin wrote:
> Do we need this here? Can we move this to cpp file?
Looks like we don't need this in cpp file either. We just need a declaration
`class MachineInstr;`
================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:24
+class WebAssemblyInstrInfo;
+class WebAssemblyRegisterInfo;
+
----------------
I don't think we need these two declarations?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56401/new/
https://reviews.llvm.org/D56401
More information about the llvm-commits
mailing list