[PATCH] D56401: [WebAssembly] Fix updating/moving DBG_VALUEs in RegStackify

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:13
+///
+//===----------------------------------------------------------------------===//
+
----------------
Please fix file name and description: it still says WebAssemblyUtilities.cpp


================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:47
+  }
+}
----------------
For `move` and `clone` functions, in the current code I think we are reversing the order of `DBG_VALUE` instructions if there are multiple. I'm not sure if we should preserve the order of those, but unless there's reason not to, I guess it's better to preserve the order? We can do this by simply reversely iterating the `DbgValues` vector.


================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:19
+
+#include "llvm/CodeGen/MachineBasicBlock.h"
+
----------------
Do we need this here? Can we move this to cpp file?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56401/new/

https://reviews.llvm.org/D56401