[PATCH] D56576: gn build: Create a template for unix toolchains.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked 3 inline comments as done.
pcc added inline comments.


================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:140
 
 toolchain("win") {
   cl = "cl"
----------------
thakis wrote:
> Should we set current_os in the win toolchain too? OK to defer that until we actually need it too, but the failure mode for not having it here and trying to use current_os in a cross build involving a win toolchain is probably a bit confusing unless you know what's needed to fix it.
Makes sense, done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56576/new/

https://reviews.llvm.org/D56576