[PATCH] D56576: gn build: Create a template for unix toolchains.

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lgtm!



================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:37
+    tool("alink") {
+      if (current_os == "mac") {
+        command = "libtool -static -no_warning_for_no_symbols {{arflags}} -o {{output}} {{inputs}}"
----------------
Please mention the host_os->current_os change in this file in the CL description too.


================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:140
 
 toolchain("win") {
   cl = "cl"
----------------
Should we set current_os in the win toolchain too? OK to defer that until we actually need it too, but the failure mode for not having it here and trying to use current_os in a cross build involving a win toolchain is probably a bit confusing unless you know what's needed to fix it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56576/new/

https://reviews.llvm.org/D56576