[PATCH] D56329: Fix some warnings on MSVC

Fri Jan 11 13:16:51 PST 2019

aganea added a comment.

In D56329#1348784 <https://reviews.llvm.org/D56329#1348784>, @gkistanova wrote:

> > 1. ignore "warning LNK4199: /DELAYLOAD:shell32.dll ignored; no imports found from shell32.dll
>
> Doesn't this warning indicate that Kaleidoscope-Ch2 is not actually calling any functions from the shell32.dll it is trying to delay-load.
>  Fixing it instead of disabling the warning might be a better move, what do you think?

I've tried several things and I can't find a good way to do that. Would you have anything to suggest?
`-delayload:shell32.dll` is added in `/llvm/trunk/lib/Support/CMakeLists.txt`. I don't see how to disable that from within `/llvm/trunk/examples/Kaleidoscope/Chapter2/CMakeLists.txt`?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56329/new/

https://reviews.llvm.org/D56329