[PATCH] D56329: Fix some warnings on MSVC
Galina via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 7 13:32:30 PST 2019
gkistanova added a comment.
Thanks for working on this, Alexandre!
> 1. ignore "warning LNK4199: /DELAYLOAD:shell32.dll ignored; no imports found from shell32.dll
Doesn't this warning indicate that Kaleidoscope-Ch2 is not actually calling any functions from the shell32.dll it is trying to delay-load.
Fixing it instead of disabling the warning might be a better move, what do you think?
The rest looks good to me.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56329/new/
https://reviews.llvm.org/D56329
More information about the llvm-commits
mailing list