[PATCH] D56094: [WebAssembly] Fix stack pointer store check in RegStackify
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 15:11:33 PST 2019
aheejin added a comment.
In D56094#1353124 <https://reviews.llvm.org/D56094#1353124>, @sunfish wrote:
> @aheejin The issue is that the current code doesn't distinguish between reading and writing of the stack pointer. Calls don't effectively modify the stack pointer, but they do read the stack pointer. Instructions which modify the stack pointer shouldn't be reordered past calls.
>
> So if we generalized this to track stack pointer reads separately from writes, then we could allow stack-pointer-reading instructions to be reordered across each other.
I see, thanks!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56094/new/
https://reviews.llvm.org/D56094
More information about the llvm-commits
mailing list