[PATCH] D56094: [WebAssembly] Fix stack pointer store check in RegStackify

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 10:55:31 PST 2019


sunfish added a comment.

@aheejin The issue is that the current code doesn't distinguish between reading and writing of the stack pointer. Calls don't effectively modify the stack pointer, but they do read the stack pointer. Instructions which modify the stack pointer shouldn't be reordered past calls.

So if we generalized this to track stack pointer reads separately from writes, then we could allow stack-pointer-reading instructions to be reordered across each other.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56094/new/

https://reviews.llvm.org/D56094





More information about the llvm-commits mailing list