[llvm] r350898 - [llvm-objcopy] [COFF] Fix warnings abuilt missing field initialization. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 13:59:41 PST 2019


Author: mstorsjo
Date: Thu Jan 10 13:59:41 2019
New Revision: 350898

URL: http://llvm.org/viewvc/llvm-project?rev=350898&view=rev
Log:
[llvm-objcopy] [COFF] Fix warnings abuilt missing field initialization. NFC.

Modified:
    llvm/trunk/tools/llvm-objcopy/COFF/Object.h
    llvm/trunk/tools/llvm-objcopy/COFF/Reader.cpp

Modified: llvm/trunk/tools/llvm-objcopy/COFF/Object.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/COFF/Object.h?rev=350898&r1=350897&r2=350898&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/COFF/Object.h (original)
+++ llvm/trunk/tools/llvm-objcopy/COFF/Object.h Thu Jan 10 13:59:41 2019
@@ -25,6 +25,9 @@ namespace objcopy {
 namespace coff {
 
 struct Relocation {
+  Relocation() {}
+  Relocation(const object::coff_relocation& R) : Reloc(R) {}
+
   object::coff_relocation Reloc;
   size_t Target;
   StringRef TargetName; // Used for diagnostics only

Modified: llvm/trunk/tools/llvm-objcopy/COFF/Reader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/COFF/Reader.cpp?rev=350898&r1=350897&r2=350898&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/COFF/Reader.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/COFF/Reader.cpp Thu Jan 10 13:59:41 2019
@@ -73,7 +73,7 @@ Error COFFReader::readSections(Object &O
       return errorCodeToError(EC);
     ArrayRef<coff_relocation> Relocs = COFFObj.getRelocations(Sec);
     for (const coff_relocation &R : Relocs)
-      S.Relocs.push_back(Relocation{R});
+      S.Relocs.push_back(R);
     if (auto EC = COFFObj.getSectionName(Sec, S.Name))
       return errorCodeToError(EC);
     if (Sec->hasExtendedRelocations())




More information about the llvm-commits mailing list