[llvm] r350897 - gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 13:57:07 PST 2019


Author: pcc
Date: Thu Jan 10 13:57:07 2019
New Revision: 350897

URL: http://llvm.org/viewvc/llvm-project?rev=350897&view=rev
Log:
gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory.

This makes it compatible with worktrees.

Differential Revision: https://reviews.llvm.org/D56422

Modified:
    llvm/trunk/utils/gn/build/write_vcsrevision.py

Modified: llvm/trunk/utils/gn/build/write_vcsrevision.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/write_vcsrevision.py?rev=350897&r1=350896&r2=350897&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/write_vcsrevision.py (original)
+++ llvm/trunk/utils/gn/build/write_vcsrevision.py Thu Jan 10 13:57:07 2019
@@ -12,7 +12,6 @@ import sys
 
 THIS_DIR = os.path.abspath(os.path.dirname(__file__))
 LLVM_DIR = os.path.dirname(os.path.dirname(os.path.dirname(THIS_DIR)))
-MONO_DIR = os.path.dirname(LLVM_DIR)
 
 
 def which(program):
@@ -36,21 +35,23 @@ def main():
     if os.path.isdir(os.path.join(LLVM_DIR, '.svn')):
         print('SVN support not implemented', file=sys.stderr)
         return 1
-    if os.path.isdir(os.path.join(LLVM_DIR, '.git')):
+    if os.path.exists(os.path.join(LLVM_DIR, '.git')):
         print('non-mono-repo git support not implemented', file=sys.stderr)
         return 1
 
-    git_dir = os.path.join(MONO_DIR, '.git')
-    if not os.path.isdir(git_dir):
-        print('.git dir not found at "%s"' % git_dir, file=sys.stderr)
-        return 1
-
     git, use_shell = which('git'), False
     if not git:
         git = which('git.exe')
     if not git:
         git = which('git.bat')
         use_shell = True
+
+    git_dir = subprocess.check_output([git, 'rev-parse', '--git-dir'],
+                                      cwd=LLVM_DIR, shell=use_shell).strip()
+    if not os.path.isdir(git_dir):
+        print('.git dir not found at "%s"' % git_dir, file=sys.stderr)
+        return 1
+
     rev = subprocess.check_output([git, 'rev-parse', '--short', 'HEAD'],
                                   cwd=git_dir, shell=use_shell).decode().strip()
     # FIXME: add pizzas such as the svn revision read off a git note?




More information about the llvm-commits mailing list