[PATCH] D55940: Detect incorrect FileCheck variable CLI definition

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A couple of comment phrasing nits.

I agree that the CommandLine feature should be added first in its own patch, and the FileCheck change done separately.



================
Comment at: llvm/lib/Support/CommandLine.cpp:430
+  // If the argument before the = is a valid option name and the option does
+  // support only the prefix form, we match.  If not, return Arg unmolested.
   auto I = Sub.OptionsMap.find(Arg.substr(0, EqualPos));
----------------
Say "supports" rather than "does support" here, it would be a more natural phrasing.


================
Comment at: llvm/lib/Support/CommandLine.cpp:546
     if (!Value.data()) { // No value specified?
-      if (i + 1 >= argc)
+      // If no other argument or option only support prefix form, we cannot
+      // look at next argument.
----------------
"or the option only supports the prefix form" will read better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55940/new/

https://reviews.llvm.org/D55940