[PATCH] D55940: Detect incorrect FileCheck variable CLI definition

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:430
   // If the argument before the = is a valid option name, we match.  If not,
   // return Arg unmolested.
   auto I = Sub.OptionsMap.find(Arg.substr(0, EqualPos));
----------------
probinson wrote:
> You've made this comment incorrect now, please update.
I think you mean "does //not// support".  When the option only supports the prefix form, we return nullptr (and Arg is "unmolested"), so we don't match.

While you're at it, could you clarify that the "unmolested" case returns nullptr?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55940/new/

https://reviews.llvm.org/D55940