[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: test/sanitizer_common/CMakeLists.txt:43
+if (ANDROID OR WINDOWS)
+	set(SUPPORTED_TOOLS ${SUPPORTED_TOOLS_LEGACY})
+	message(
----------------
For simplicity you can drop SUPPORTED_TOOLS_LEGACY and just use:
If Windows SUPPORTED_TOOLS=""
If Android SUPPORTED_TOOLS="asan"


================
Comment at: test/sanitizer_common/TestCases/symbolize_stack.cc:6
+// FIXME(dliew): Make this test work with the other sanitizers.
+// UNSUPPORTED: darwin && (lsan || tsan || ubsan)
+
----------------
delcypher wrote:
> vitalybuka wrote:
> > why is this not XFAIL? 
> I think the original reason was the for LSan on i386 it would hang (crashed while doing stop-the-world). However because I prevent those tests being run from `ninja check-sanitizer` in the `CMakeLists.txt` file, using `XFAIL`, is probably okay.
Thanks.
Yes, question was just about XFAIL vs UNSOPPORTED. Former has some benefits if we expect to fix it (and it fails consistently).


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740